Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: re-export raw-window-handle crate #1067

Merged
merged 2 commits into from
Nov 11, 2023
Merged

feat: re-export raw-window-handle crate #1067

merged 2 commits into from
Nov 11, 2023

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Nov 9, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

Other information

I didn't add a file under .changes directory because this change can be amended to changes of #1041.

@rhysd rhysd requested a review from a team as a code owner November 9, 2023 14:32
@rhysd rhysd force-pushed the pub-has-rwh branch 2 times, most recently from 41cd130 to dc3c3cc Compare November 9, 2023 14:35
@amrbashir
Copy link
Member

I would prefer to re-export the whole raw-window-handle crate.

@rhysd
Copy link
Contributor Author

rhysd commented Nov 10, 2023

That also makes sense to me. Do you have any suggestion about module name?

  • wry::raw_window_handle
  • wry::rwh

@amrbashir
Copy link
Member

raw_window_handle is fine

@rhysd
Copy link
Contributor Author

rhysd commented Nov 10, 2023

Sure. I will do the change tonight.

@rhysd rhysd changed the title feat: make HasRawWindowHandle trait public feat: re-export raw-window-handle crate Nov 10, 2023
@rhysd
Copy link
Contributor Author

rhysd commented Nov 10, 2023

@amrbashir I updated this branch based on your comments.

@wusyong wusyong merged commit d57f94e into tauri-apps:dev Nov 11, 2023
10 checks passed
@github-actions github-actions bot mentioned this pull request Nov 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make HasRawWindowHandle public
3 participants
@rhysd @amrbashir @wusyong